Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Commit

Permalink
Add TODO about features to test once we bump MSRV
Browse files Browse the repository at this point in the history
We get build errors when building with Rust 1.29 for `core2` and
`schemars`. Add todos to remind us to test theses once we bump MSRV.

Note the `schemars` cannot be added to the test matrix because it must
be built with `std`, we must add a specific test for this combination.

Example build error:

```
error: unable to get packages from source

Caused by:
failed to parse manifest at `/home/tobin/.cargo/registry/src/github.com-1ecc6299db9ec823/core2-0.3.3/Cargo.toml`

Caused by:
editions are unstable

Caused by:
feature `edition` is required
```

Add a TODO to `test.sh` to remind us to add `core2` to the features
matrix once we bump MSRV.

Add schemars/std test
  • Loading branch information
tcharding committed Feb 2, 2022
1 parent 41807c0 commit af992d7
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions contrib/test.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/sh -ex

# TODO: Add core2 here once we bump MSRV past 1.29
FEATURES="serde serde-std std"

if [ "$DO_ALLOC_TESTS" = true ]; then
Expand Down Expand Up @@ -41,6 +42,9 @@ if [ "$DO_FEATURE_MATRIX" = true ]; then
done
done

# Other combos
# TODO: Add this test once we bump MSRV past 1.29
# cargo test --all --no-default-features --features="std,schemars"
fi

if [ "$DO_SCHEMARS_TESTS" = true ]; then
Expand Down

0 comments on commit af992d7

Please sign in to comment.