Use foreground colors instead of background colors to highlight diffs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using foreground color would hide whitespace changes, which may be confusing in some cases. If that is a strong enough argument to keep changing the background color, I guess not. |
|
This bothered me a lot, and it looks much better now. But it might be possible to keep the background color on the whitespace characters, how does that sound? |
|
I'd rather keep this PR as a small tweak rather than making too many changes to the diffing algorithm (e.g. by detecting significant whitespace changes). How about showing the changes underlined like this?
|
lnicola
approved these changes
Feb 11, 2023
|
Hey, any thoughts on whether this PR should be merged? |
|
Thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think foreground colors are more "standard", and the background colors make things unreadable in my color scheme.
Before:
After:
