Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse string literals to find their length #23

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Parse string literals to find their length #23

merged 2 commits into from
Dec 25, 2021

Conversation

ecstatic-morse
Copy link
Contributor

Fixes #20. A more complete alternative to #21.

@ecstatic-morse
Parse string literals to find their length.
a13fe99 
This makes the double brackets somewhat unnecessary. Now they are just
used to find the macro invocation, though we should be able to get that
with the data in `Position`.
@ecstatic-morse
Account for whitespace between expect![[ and the literal
52dcaad
@matklad
Copy link
Member

matklad commented Dec 25, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 25, 2021

Build succeeded:

@bors bors bot merged commit c60f9a0 into rust-analyzer:master Dec 25, 2021
@matklad
Copy link
Member

matklad commented Dec 25, 2021

published as 1.2.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"]]" inside an expect breaks updating
2 participants
@ecstatic-morse @matklad