Pr.microsoft.gsl #1499
Pr.microsoft.gsl #1499
Conversation
| VERSION | ||
| 1.0.0 | ||
| URL | ||
| "https://github.com/ithron/GSL/archive/v1.0.0-h.tar.gz" |
There was a problem hiding this comment.
Probably it make sense to wait for microsoft/GSL#708 to be merged and use https://github.com/Microsoft/GSL ?
There was a problem hiding this comment.
This is for the 1.0.0 release. So even they merge the PR, the v1.0.0 release won't be updated.
There was a problem hiding this comment.
As a temporary solution you can put random SHA1 here like:
URL
"https://github.com/Microsoft/GSL/archive/5778149583e69b34ab375039ffcc5d51a4dd7b37.zip"
SHA1
"..."so we really need to wait only pull request to be merged.
If it still not what you want then there is a central place for forks: https://github.com/hunter-packages/ I can create GSL fork there and give you write permissions.
There was a problem hiding this comment.
The problem is I'd like the 1.0.0 hunter package to reference to the original 1.0.0 release.
If I change the URL to point to the PL merge, the hunter package would include some pre-release code, which might not be what users expect.
I think a fork on hunter-packages would be a good solution.
There was a problem hiding this comment.
the hunter package would include some pre-release code, which might not be what users expect
Branch hunter-1.0.0 created based on v1.0.0 tag: https://github.com/hunter-packages/Microsoft.GSL
@ithron I've added you to team (check email), you will be able to push to branches directly but it's better for review reason to create pull request. Please read: https://docs.hunter.sh/en/latest/creating-new/patch.html
docs/packages/pkg/Microsoft.GSL.rst
Outdated
| .. _pkg.Microsoft.GSL: | ||
|
|
||
| Microsoft.GSL | ||
| === |
There was a problem hiding this comment.
Please use ============= instead of ===.
| PACKAGE_NAME | ||
| Microsoft.GSL | ||
| VERSION | ||
| 1.0.0 |
There was a problem hiding this comment.
Please make it 1.0.0-p0 so it will be clear that patched version used.
docs/packages/pkg/Microsoft.GSL.rst
Outdated
| ============= | ||
|
|
||
| - `Official <https://github.com/Microsoft/GSL>`__ | ||
| - `Hunterized <https://github.com/ithron/GSL/tree/v1.0.0-h>`__ |
There was a problem hiding this comment.
There was a problem hiding this comment.
This one left. The rest looks good.
docs/packages/pkg/Microsoft.GSL.rst
Outdated
| ============= | ||
|
|
||
| - `Official <https://github.com/Microsoft/GSL>`__ | ||
| - `Hunterized <https://github.com/ithron/GSL/tree/v1.0.0-h>`__ |
There was a problem hiding this comment.
This one left. The rest looks good.
cmake/configs/default.cmake
Outdated
| @@ -88,6 +88,7 @@ hunter_default_version(Libcxxabi VERSION 3.6.2) # Clang | |||
| hunter_default_version(Libevent VERSION 2.1.8-p4) | |||
| hunter_default_version(Libssh2 VERSION 1.7.0) | |||
| hunter_default_version(Lua VERSION 5.3.2-p2) | |||
| hunter_default_version(Microsoft.GSL VERSION 1.0.0) | |||
I've followed this guide
step by step carefully. Yes
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
I have submitted CI configs to https://github.com/ingenue/hunter targeting
pkg.templatebranch,see this merged pull request Test 'Microsoft.GSL' package ingenue/hunter#269