-
Notifications
You must be signed in to change notification settings - Fork 653
Conversation
cmake/projects/flex/hunter.cmake
Outdated
hunter_pick_scheme(DEFAULT url_sha1_autotools) | ||
hunter_cacheable(flex) | ||
hunter_download(PACKAGE_NAME flex | ||
PACKAGE_INTERNAL_DEPS_ID "1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PACKAGE_INTERNAL_DEPS_ID "1"
not needed
cmake/projects/flex/hunter.cmake
Outdated
|
||
include(hunter_add_version) | ||
include(hunter_cacheable) | ||
include(hunter_cmake_args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used
docs/packages/pkg/flex.rst
Outdated
|
||
- `Official <https://github.com/westes/flex/>`__ | ||
- `Example <https://github.com/ruslo/hunter/blob/master/examples/flex/CMakeLists.txt>`__ | ||
- Added by `Isaac Hier <https://github.com/isaachier>`__ (`pr-N <https://github.com/ruslo/hunter/pull/N>`__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s,N,1039,
docs/packages/pkg/flex.rst
Outdated
|
||
.. code-block:: cmake | ||
|
||
# Based on https://cmake.org/cmake/help/v3.0/module/FindFLEX.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it make sense to create minimal example with find_package(FLEX)
+ hunter_add_package(flex)
and without Bison. You can create two blocks with CMake code if you think that Bison + Flex example is useful.
docs/packages/pkg/flex.rst
Outdated
.. code-block:: cmake | ||
|
||
# Based on https://cmake.org/cmake/help/v3.0/module/FindFLEX.html. | ||
# TODO: hunter_add_package(bison) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation build failed.
docs/packages/pkg/flex.rst
Outdated
- Added by `Isaac Hier <https://github.com/isaachier>`__ (`pr-1039 <https://github.com/ruslo/hunter/pull/1039>`__) | ||
|
||
.. code-block:: cmake | ||
# Simple flex example (no bison). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use this as a title before code block instead of using it as a comment.
docs/packages/pkg/flex.rst
Outdated
|
||
.. code-block:: cmake | ||
# More complex example involving flex and bison. Based on | ||
# https://cmake.org/cmake/help/v3.0/module/FindFLEX.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use RST features and add link
`FindFLEX <https://cmake.org/cmake/help/v3.0/module/FindFLEX.html>`__
All Windows toolchains failed. I guess because autotools is not working on Windows. Please exclude all toolchains in |
No description provided.