Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Add Flex package. #1039

Merged
merged 5 commits into from
Sep 16, 2017
Merged

Add Flex package. #1039

merged 5 commits into from
Sep 16, 2017

Conversation

isaachier
Copy link
Contributor

No description provided.

hunter_pick_scheme(DEFAULT url_sha1_autotools)
hunter_cacheable(flex)
hunter_download(PACKAGE_NAME flex
PACKAGE_INTERNAL_DEPS_ID "1")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PACKAGE_INTERNAL_DEPS_ID "1" not needed


include(hunter_add_version)
include(hunter_cacheable)
include(hunter_cmake_args)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used


- `Official <https://github.com/westes/flex/>`__
- `Example <https://github.com/ruslo/hunter/blob/master/examples/flex/CMakeLists.txt>`__
- Added by `Isaac Hier <https://github.com/isaachier>`__ (`pr-N <https://github.com/ruslo/hunter/pull/N>`__)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s,N,1039,


.. code-block:: cmake

# Based on https://cmake.org/cmake/help/v3.0/module/FindFLEX.html.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it make sense to create minimal example with find_package(FLEX) + hunter_add_package(flex) and without Bison. You can create two blocks with CMake code if you think that Bison + Flex example is useful.

.. code-block:: cmake

# Based on https://cmake.org/cmake/help/v3.0/module/FindFLEX.html.
# TODO: hunter_add_package(bison)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Owner

@ruslo ruslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation build failed.

- Added by `Isaac Hier <https://github.com/isaachier>`__ (`pr-1039 <https://github.com/ruslo/hunter/pull/1039>`__)

.. code-block:: cmake
# Simple flex example (no bison).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this as a title before code block instead of using it as a comment.


.. code-block:: cmake
# More complex example involving flex and bison. Based on
# https://cmake.org/cmake/help/v3.0/module/FindFLEX.html.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use RST features and add link

`FindFLEX <https://cmake.org/cmake/help/v3.0/module/FindFLEX.html>`__

@ruslo
Copy link
Owner

ruslo commented Sep 14, 2017

All Windows toolchains failed. I guess because autotools is not working on Windows. Please exclude all toolchains in appveyor.yml and add toolchain with name dummy. Some OSX/Linux toolchains failed, feel free to exclude/fix. If you want to exclude please send pull request to branch pkg.flex. Example: https://github.com/ingenue/hunter/pull/56/files

@ruslo ruslo merged commit 7a39322 into ruslo:master Sep 16, 2017
@ruslo
Copy link
Owner

ruslo commented Sep 16, 2017

@isaachier isaachier deleted the flex branch April 24, 2018 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants