Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Gradle Doctor Compatible with the configuration cache #71

Closed
runningcode opened this issue Jul 9, 2020 · 6 comments
Closed

Make Gradle Doctor Compatible with the configuration cache #71

runningcode opened this issue Jul 9, 2020 · 6 comments

Comments

@runningcode
Copy link
Owner

https://docs.gradle.org/release-nightly/userguide/configuration_cache.html
@ZacSweers
Copy link
Contributor 

- plugin 'com.osacky.doctor': registration of listener on 'Gradle.buildFinished' is unsupported
  See https://docs.gradle.org/6.6-rc-6/userguide/configuration_cache.html#config_cache:requirements:build_listeners

@ZacSweers
Copy link
Contributor 

at com.osacky.doctor.BuildOperations.<init>(BuildOperations.kt:55)
	at com.osacky.doctor.DoctorPlugin.apply(DoctorPlugin.kt:35)
	at com.osacky.doctor.DoctorPlugin.apply(DoctorPlugin.kt:21)

@ZacSweers
Copy link
Contributor 

at com.osacky.doctor.DoctorPlugin.apply(DoctorPlugin.kt:51)
	at com.osacky.doctor.DoctorPlugin.apply(DoctorPlugin.kt:21)

@ZacSweers ZacSweers mentioned this issue Aug 8, 2020
Closed
@eskatos eskatos mentioned this issue Aug 12, 2020
Open
runningcode added a commit that referenced this issue Aug 12, 2020
@runningcode
Add initial configuration cache compatibility.
120d920 
This stops any configuraiton cache warnings from happening during a normal build. This does not mean that the build is fully compatibly with configuration caching or that it even works.

Ref #71
@runningcode runningcode mentioned this issue Aug 12, 2020
Merged
runningcode added a commit that referenced this issue Aug 12, 2020
@runningcode
Add initial configuration cache compatibility.
c1ffec5 
This stops any configuraiton cache warnings from happening during a normal build. This does not mean that the build is fully compatibly with configuration caching or that it even works.

Ref #71
runningcode added a commit that referenced this issue Aug 13, 2020
@runningcode
Add initial configuration cache compatibility. (#102)
62b8842 
This stops any configuraiton cache warnings from happening during a normal build. This does not mean that the build is fully compatibly with configuration caching or that it even works.

Ref #71
runningcode added a commit that referenced this issue Sep 17, 2020
@runningcode
Improve configuration caching compatibility.
044cebb 
This uses new BuildService and BuildEventListenerRegistry to listen to build events.

Ref #71
@runningcode runningcode mentioned this issue Sep 17, 2020
Merged
runningcode added a commit that referenced this issue Sep 17, 2020
@runningcode
Improve configuration caching compatibility.
6abb225 
This uses new BuildService and BuildEventListenerRegistry to listen to build events.

Ref #71
runningcode added a commit that referenced this issue Sep 21, 2020
@runningcode
Improve configuration caching compatibility. (#116)
51580cf 
This uses new BuildService and BuildEventListenerRegistry to listen to build events.

Ref #71
@nedtwigg nedtwigg mentioned this issue Oct 15, 2020
Closed
@high-stakes high-stakes mentioned this issue Jun 29, 2021
Closed
@ColtonIdle
Copy link

Looks like there were some PRs to target configuration cache support in gradle doctor, but just wanted to point out today that AS in the config cache tool shown at ADS points out gradle doctor as "unsupported"
Screen Shot 2021-10-28 at 11 14 33 PM

@runningcode
Copy link
Owner Author

runningcode commented Oct 31, 2021 •
edited
Loading

The message does not say that it is unsupported. It says that it was not able to recognize the plugin. If you try configuration cache in a build, it should work fine with Gradle Doctor. If not could you please upload the configuration cache report html?

@ColtonIdle
Copy link

@runningcode that's my mistake for misinterpreting that message. Just trying to be proactive. Sorry for bothering you with it. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@runningcode @ZacSweers @ColtonIdle