Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复view 中解析配置的schema,columns -》 name的问题 #1825

Merged

Conversation

KANLON
Copy link
Contributor

@KANLON KANLON commented Aug 5, 2022

我发现在1.0.0-beta.3中,保存view的时候,列的信息中 columns -》 name 的值是字符串来的,但是到了1.0.0-beta.4 中 columns -》 name 的值是数组来的,然后这部分DataProviderServiceImpl#parseSchema 在 1.0.0-beta.4 版本去执行之前 版本所保存的view,关联的datachart图就会报解析错误了,因为之前的代码解析是默认将name当做数组解析了,所以导致name为字符串的时候就报错了。

我修改的代码就是判断一下类型,是数组的才用数组解析,否则都获取字符串对象

具体的报错信息如下:

ERROR datart.server.service.impl.DataProviderServiceImpl : view model parse error
com.alibaba.fastjson.JSONException: syntax error, pos 1, line 1, column 2dt
at com.alibaba.fastjson.parser.DefaultJSONParser.parse(DefaultJSONParser.java:1487)
at com.alibaba.fastjson.parser.DefaultJSONParser.parse(DefaultJSONParser.java:1373)

目前这个影响的主要是解析parseSchema 这里,应该不影响界面功能,不过好像聚合那里用到schema,可能会影响聚合

麻烦大佬有空的时候,帮忙code review一下代码了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants