Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复指标操作格式之后数据混乱的问题 #1637

Merged
merged 2 commits into from
Jul 13, 2022
Merged

fix: 修复指标操作格式之后数据混乱的问题 #1637

merged 2 commits into from
Jul 13, 2022

Conversation

TMBigGroup
Copy link
Contributor

@scottsut scottsut requested a review from Cuiyansong July 13, 2022 08:11
Cuiyansong
Cuiyansong reviewed Jul 13, 2022
View reviewed changes
frontend/src/app/hooks/useStateModal.tsx Outdated
@@ -62,6 +62,8 @@ function useStateModal({ initState }: { initState?: any }) {
Object.create(null),
...spreadParmas,
);
// @TM 清空
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, the modal should be recreated after close, but...so, it is better to clear the ref state, 👍🏿 .
Additional, could you remove the todo comment on this? the fix is ok for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, the modal should be recreated after close, but...so, it is better to clear the ref state, 👍🏿 . Additional, could you remove the todo comment on this? the fix is ok for me.

ok

Cuiyansong
Cuiyansong reviewed Jul 13, 2022
View reviewed changes
frontend/src/app/hooks/useStateModal.tsx Outdated
@@ -74,6 +76,8 @@ function useStateModal({ initState }: { initState?: any }) {
};

const handleClickCancelButton = () => {
// @TM 清空
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above.

SoarBlueSky
SoarBlueSky previously approved these changes Jul 13, 2022
View reviewed changes
@Cuiyansong Cuiyansong merged commit 1de8da0 into running-elephant:dev Jul 13, 2022
@Cuiyansong
Copy link
Contributor

感谢贡献！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cuiyansong Cuiyansong Cuiyansong approved these changes

@SoarBlueSky SoarBlueSky SoarBlueSky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TMBigGroup @Cuiyansong @SoarBlueSky