Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugs #1545

Merged
merged 13 commits into from
Jul 1, 2022
Merged

Fix Bugs #1545

merged 13 commits into from
Jul 1, 2022

Conversation

Cuiyansong
Copy link
Contributor

No description provided.

scottsut
scottsut previously approved these changes Jun 30, 2022
return source;
} catch (error) {
errorHandle(error);
reject && reject();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 reject 逻辑丢掉了

Copy link
Contributor Author

@Cuiyansong Cuiyansong Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦哦,稍后commit加上~。
不过好像这个editSource从来没有给过reject func

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看了下代码,确实……
这块可能是哪次改动后的遗留代码,那不改也没关系了

@Cuiyansong Cuiyansong merged commit 6d9a68d into running-elephant:dev Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants