Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch docs config from sphinx to mkdocs #42

Merged
merged 9 commits into from
May 24, 2024
Merged

Conversation

setu4993
Copy link
Member

This PR is a full revamp of the docs for Protect to use mkdocs from sphinx. It allows us to use markdown, while also exposing a bunch of helpers and functions from galileo-core inline as we wanted to, while being more searchable, easier to write and maintain.

Changes:

  • feat: Update docs from Sphinx => mkdocs
  • chore: Ignore mkdocs auto
  • feat: Configure mkdocs
  • ci: Update docs build process
  • ci: Fix path for GH pages config
  • chore(deps): Switch to mkdocs
  • ci: Include CNAME in docs dir

I cheated and deployed it already. Go see example: https://protect.docs.rungalileo.io/

@setu4993 setu4993 requested a review from a team as a code owner May 23, 2024 23:59
@setu4993 setu4993 requested a review from franz101 May 23, 2024 23:59
@franz101
Copy link

The mk docs look really amazing, the only issue right now I have there is no way to search across different tools. Mainly from a user perspective searching for a function on https://docs.rungalileo.io won't lead to protect.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (057ce63) to head (a58477b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files           2        2           
  Lines         108      108           
=======================================
  Hits           69       69           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@setu4993
Copy link
Member Author

The mk docs look really amazing, the only issue right now I have there is no way to search across different tools. Mainly from a user perspective searching for a function on https://docs.rungalileo.io won't lead to protect.

True, but that's tangential. It doesn't change the status quo, but it does in fact gets us closer to being able to change it because we can migrate docs to use mkdocs instead of GitBook.

@setu4993 setu4993 requested a review from dmallon May 24, 2024 00:27
@franz101
Copy link

Curious, Is this the plan to move off git books (from product side)?

@setu4993
Copy link
Member Author

Curious, Is this the plan to move off git books (from product side)?

From what I talked to Quique: We are open to it and not tied to GitBook if we don't have to do a ton of work and get clear benefits. I'll experiment with bringing all API docs alongside actual docs from our other libraries in a couple weeks to see if we can get to something nicer with mkdocs.

@setu4993 setu4993 merged commit 433381e into main May 24, 2024
9 checks passed
@setu4993 setu4993 deleted the docs/mkdocs branch May 24, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants