-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch docs config from sphinx
to mkdocs
#42
Conversation
The mk docs look really amazing, the only issue right now I have there is no way to search across different tools. Mainly from a user perspective searching for a function on https://docs.rungalileo.io won't lead to protect. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 2 2
Lines 108 108
=======================================
Hits 69 69
Misses 39 39 ☔ View full report in Codecov by Sentry. |
True, but that's tangential. It doesn't change the status quo, but it does in fact gets us closer to being able to change it because we can migrate docs to use mkdocs instead of GitBook. |
Curious, Is this the plan to move off git books (from product side)? |
From what I talked to Quique: We are open to it and not tied to GitBook if we don't have to do a ton of work and get clear benefits. I'll experiment with bringing all API docs alongside actual docs from our other libraries in a couple weeks to see if we can get to something nicer with |
This PR is a full revamp of the docs for Protect to use
mkdocs
fromsphinx
. It allows us to use markdown, while also exposing a bunch of helpers and functions fromgalileo-core
inline as we wanted to, while being more searchable, easier to write and maintain.Changes:
mkdocs
I cheated and deployed it already. Go see example: https://protect.docs.rungalileo.io/