-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support filtering for reviewed only edits #881
Merged
vpogrebi
merged 20 commits into
main
from
21961_export_parity_between_get_dataframe_and_NLP_studio
Dec 9, 2024
Merged
feat: Support filtering for reviewed only edits #881
vpogrebi
merged 20 commits into
main
from
21961_export_parity_between_get_dataframe_and_NLP_studio
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NLP studio 1. Added `approved_only` optional argument to `ApiClient.get_edits()` and `ApiClient.export_edits()` procedures. This requires new `api` package version - which takes extra `approved_only` argument for its Get Run Edits request 2. Added `approved_only` optional argument to `metrics.get_edited_dataframe()` procedure Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
NLP studio Added optional argument `reviewed_only` to `metrics.get_edited_dataframe()` and a code to filter DataFrame to only contain reviewed edits when this argument is set to True. Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
setu4993
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start. Can we add a test for this please?
Co-authored-by: Setu Shah <setu@rungalileo.io>
setu4993
changed the title
feat: [SHORTCUT-21961] - [API, NLP] export parity between dq.get_dataframe() and NLP studio
feat: Support filtering for reviewed only edits
Dec 9, 2024
setu4993
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the new tests!
vpogrebi
deleted the
21961_export_parity_between_get_dataframe_and_NLP_studio
branch
December 9, 2024 18:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
reviewed_only
optional argument tometrics.get_edited_dataframe()
procedure and added logic to filter DataFrame when this argument is True.https://app.shortcut.com/galileo/story/21961/api-nlp-export-parity-between-dq-get-dataframe-and-nlp-studio