Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support filtering for reviewed only edits #881

Merged

Conversation

vpogrebi
Copy link
Contributor

@vpogrebi vpogrebi commented Dec 4, 2024

Added reviewed_only optional argument to metrics.get_edited_dataframe() procedure and added logic to filter DataFrame when this argument is True.

https://app.shortcut.com/galileo/story/21961/api-nlp-export-parity-between-dq-get-dataframe-and-nlp-studio

NLP studio

1. Added `approved_only` optional argument to `ApiClient.get_edits()`
and `ApiClient.export_edits()` procedures. This requires new `api`
package version - which takes extra `approved_only` argument for its Get
Run Edits request
2. Added `approved_only` optional argument to
`metrics.get_edited_dataframe()` procedure

Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
NLP studio

Added optional argument `reviewed_only` to
`metrics.get_edited_dataframe()` and a code to filter DataFrame to only
contain reviewed edits when this argument is set to True.

Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
@vpogrebi vpogrebi marked this pull request as ready for review December 5, 2024 18:12
@vpogrebi vpogrebi requested a review from a team as a code owner December 5, 2024 18:12
@vpogrebi vpogrebi requested a review from setu4993 December 5, 2024 18:13
Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. Can we add a test for this please?

dataquality/metrics.py Outdated Show resolved Hide resolved
vpogrebi and others added 6 commits December 5, 2024 17:46
Co-authored-by: Setu Shah <setu@rungalileo.io>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
@vpogrebi vpogrebi marked this pull request as draft December 6, 2024 18:55
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
Signed-off-by: Valeriy Pogrebitskiy <vpogrebi@iname.com>
@vpogrebi vpogrebi marked this pull request as ready for review December 6, 2024 23:57
@setu4993 setu4993 changed the title feat: [SHORTCUT-21961] - [API, NLP] export parity between dq.get_dataframe() and NLP studio feat: Support filtering for reviewed only edits Dec 9, 2024
Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the new tests!

@vpogrebi vpogrebi merged commit b5c68aa into main Dec 9, 2024
3 checks passed
@vpogrebi vpogrebi deleted the 21961_export_parity_between_get_dataframe_and_NLP_studio branch December 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants