Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model_upload): Add tokenizer to upload_model_to_dq function #853

Merged
merged 2 commits into from
May 3, 2024
Merged

feat(model_upload): Add tokenizer to upload_model_to_dq function #853

merged 2 commits into from
May 3, 2024

Conversation

franz101
Copy link
Contributor

@franz101 franz101 commented Apr 25, 2024 •
edited
Loading

Description:
Currently we don't save the tokenizer when uploading a model

If a custom model is used besides distill-bert we cant reconstruct the tokenizer

@franz101 franz101 marked this pull request as ready for review May 3, 2024 20:19
@franz101 franz101 requested review from dcaustin33 and a team as code owners May 3, 2024 20:19
@franz101 franz101 requested a review from dmallon May 3, 2024 20:19
@franz101 franz101 enabled auto-merge (squash) May 3, 2024 23:27
@franz101 franz101 merged commit 6be5a55 into main May 3, 2024
3 checks passed
@franz101 franz101 deleted the feature/load_models branch May 3, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setu4993 setu4993 setu4993 approved these changes

@dcaustin33 dcaustin33 Awaiting requested review from dcaustin33

@dmallon dmallon Awaiting requested review from dmallon dmallon is a code owner automatically assigned from rungalileo/platform

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franz101 @setu4993