Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove version check warning #844

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

elboy3
Copy link
Contributor

@elboy3 elboy3 commented Mar 18, 2024

Shortcut:
https://app.shortcut.com/galileo/story/14149/qa-bug-tc-mltc-notebooks-problem-with-creating-new-project

Description:
Remove the major version mismatch as noticed in ☝️

This concept has not been kept up with as api has been built towards more clients than just DQ

Tests:

  • Local.
  • CI.

@elboy3
Copy link
Contributor Author

elboy3 commented Mar 18, 2024

Copy link

@elboy3 elboy3 marked this pull request as ready for review March 18, 2024 13:58
@elboy3 elboy3 requested review from dcaustin33 and a team as code owners March 18, 2024 13:58
@elboy3 elboy3 requested a review from setu4993 March 18, 2024 13:58
Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API key in the notebook 😬.

@elboy3 elboy3 force-pushed the chore/remove-version-check-warning branch from 7925777 to c0a1633 Compare March 18, 2024 18:01
@elboy3
Copy link
Contributor Author

elboy3 commented Mar 18, 2024

API key in the notebook 😬.

Gone! with interactive rebase to remove from history

Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more 🚨s for version mismatches.

@elboy3 elboy3 merged commit c070ea4 into main Mar 19, 2024
3 checks passed
@elboy3 elboy3 deleted the chore/remove-version-check-warning branch March 19, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants