Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CONTRIBUTING.md with instructions to use poetry #839

Merged
merged 2 commits into from
Mar 4, 2024
Merged

chore: Update CONTRIBUTING.md with instructions to use poetry #839

merged 2 commits into from
Mar 4, 2024

Conversation

jbeisen
Copy link
Contributor

@jbeisen jbeisen commented Mar 4, 2024

No description provided.

@jbeisen jbeisen requested review from dcaustin33 and a team as code owners March 4, 2024 00:25
@jbeisen jbeisen requested a review from setu4993 March 4, 2024 00:25
setu4993
setu4993 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending over this contribution, @jbeisen! Appreciate it.

I'll do a rework of this entire doc in the next couple weeks to handle venv management with poetry, too, but this should be helpful in the meanwhile.

CONTRIBUTING.md
This project uses `setuptools` to manage our project's dependencies and `invoke` for running tasks.
This project uses `poetry` to manage our project's dependencies and `invoke` for running tasks.

If you haven't already, make sure to [install poetry](https://python-poetry.org/docs/#installation).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding this.

@setu4993 setu4993 merged commit 1719990 into rungalileo:main Mar 4, 2024
3 checks passed
@jbeisen jbeisen deleted the chore/contributing-poetry branch March 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setu4993 setu4993 setu4993 approved these changes

@dcaustin33 dcaustin33 Awaiting requested review from dcaustin33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbeisen @setu4993