fix: auto alpaca #778
Merged
fix: auto alpaca #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 87.68% 87.70% +0.01%
==========================================
Files 184 184
Lines 15092 15127 +35
==========================================
+ Hits 13234 13267 +33
- Misses 1858 1860 +2
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
setu4993
reviewed
Oct 19, 2023
dataquality/dq_auto/schema.py
Outdated
| @@ -46,6 +48,9 @@ class BaseAutoDatasetConfig: | |||
| # Column names | |||
| input_col: str = "text" | |||
| target_col: str = "label" | |||
| # Dataset input / output formatter | |||
| max_train_size: Optional[int] = None | |||
| formatter: BaseFormatter = DefaultFormatter() | |||
There was a problem hiding this comment.
This is a more idiomatic way of initializing for a dataclass:
Suggested change
| formatter: BaseFormatter = DefaultFormatter() | |
| from dataclasses import field | |
| ... | |
| formatter: BaseFormatter = field(default_factory=DefaultFormatter) |
1d37f19 to
9695326
Compare
bump version docstring make max train size default to none remove notebook
9695326 to
50e0a87
Compare
setu4993
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into some column renaming issues that I fix in this PR
I also made some edits to allow the user to pass in an upper limit to the dataset size that is configurable in DatasetConfig
A HF dataset has a default size limit that can be upped by the user