feat: s2s auto metadata #777
Conversation
|
This pull request has been linked to Shortcut Story #8226: [DQ] Auto support for logging metadata. |
Codecov Report
@@ Coverage Diff @@
## main #777 +/- ##
==========================================
- Coverage 87.69% 87.69% -0.01%
==========================================
Files 184 184
Lines 15089 15104 +15
==========================================
+ Hits 13232 13245 +13
- Misses 1857 1859 +2
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| C.split_.value: [self.split] * len(self.ids), | ||
| C.token_label_positions.value: pa.array(self.token_label_positions), | ||
| C.token_label_offsets.value: pa.array(self.token_label_offsets), | ||
| **self.meta, |
There was a problem hiding this comment.
Just for my understanding: This could have been as a part of the previous way it was done, too, right? Or is there something special / specific here for which it needs to be different?
There was a problem hiding this comment.
ahh yes it can, i'll fix. i broke it into 2 separate cause i had a breakpoint in there, but will revert
There was a problem hiding this comment.
No worries, this is fine, I was just asking because it was a larger diff than it should've been :).
https://app.shortcut.com/galileo/story/8226/dq-auto-support-for-logging-metadata
Tested locally and it works
https://console.dev.rungalileo.io/insights/4194b985-6c2c-459b-9199-5ed53135ce5a/dd896833-bf7f-4c2a-b51e-6aa8ede6ccaa?dataframeColumns=Unnamed%3A+0%3B%26category%3B%26data_error_potential%3B%26input%3B%26lang%3B%26perplexity%3B%26raw_data_hash%3B%26source%3B%26target&taskType=8