Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: model to cpu for cuda cleanup #775

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: model to cpu for cuda cleanup #775

merged 2 commits into from
Oct 17, 2023

Conversation

elboy3
Copy link
Contributor

@elboy3 elboy3 commented Oct 16, 2023

@elboy3 elboy3 requested review from dcaustin33 and a team as code owners October 16, 2023 19:55
dcaustin33
dcaustin33 reviewed Oct 16, 2023
View reviewed changes
dataquality/utils/torch.py Outdated
for tensor in tensors:
if torch.is_tensor(tensor):
with torch.no_grad():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont need no grad here

setu4993
setu4993 requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urm, credentials in notebook.

@elboy3
This is a combination of 3 commits.
f54703e 
fix: model to cpu for cuda cleanup

dont need no grad

remove credentials
@elboy3
Copy link
Contributor Author

elboy3 commented Oct 17, 2023

Urm, credentials in notebook.

Eeek! my bad ... squashed in an interactive rebase so it's not in commit history

@elboy3 elboy3 enabled auto-merge (squash) October 17, 2023 13:12
@elboy3 elboy3 merged commit b335d1d into main Oct 17, 2023
@elboy3 elboy3 deleted the fix/model-to-cpu branch October 17, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaustin33 dcaustin33 dcaustin33 approved these changes

@setu4993 setu4993 setu4993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elboy3 @setu4993 @dcaustin33