Fixes ci tests in example notebooks #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboy3
reviewed
Jul 25, 2023
| @@ -262,7 +262,7 @@ def upload( | |||
| proj_run = f"{config.current_project_id}/{config.current_run_id}" | |||
| location = f"{self.LOG_FILE_DIR}/{proj_run}" | |||
|
|
|||
| if cuml_available(): | |||
| if cuml_available() and config.task_type != 'semantic_segmentation': | |||
There was a problem hiding this comment.
Suggested change
| if cuml_available() and config.task_type != 'semantic_segmentation': | |
| if cuml_available() and config.task_type != TaskType.semantic_segmentation: |
elboy3
reviewed
Jul 25, 2023
elboy3
approved these changes
Jul 25, 2023
anthonycorletti
approved these changes
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 89.55% 89.75% +0.20%
==========================================
Files 167 168 +1
Lines 13409 13592 +183
==========================================
+ Hits 12008 12200 +192
+ Misses 1401 1392 -9
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I re-ran the failing tests, it worked for me this AM (the dq yolo one failing for a weird reason) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue for those with cuml library installed where we tried to apply umap to embeddings even though semseg does not have any embeddings.