-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add py37 warning #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why in the Analytics init? What not in dq.init
or in the __init__.py
file when you import?
@elboy3 :
I put it here because that's where we were logging the version to Amplitude for. I personally prefer putting it in |
Codecov Report
@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 89.54% 89.50% -0.04%
==========================================
Files 166 166
Lines 13403 13393 -10
==========================================
- Hits 12002 11988 -14
- Misses 1401 1405 +4
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@setu4993 I think i'd prefer that, since we might remove amplitude in the not so far future as well |
Turns out the test that was failing in #720 was just being flaky, because of an upstream change in settings management for `ultralytics` (ultralytics/ultralytics#3790). This improves how we handle it. Tests: - [x] Local. - [ ] CI.
During the import of
dataquality
, start warning users that we're going to be dropping Python 3.7 support soon.