Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Rename text and label cols to input and target output #718

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

@elboy3 elboy3 changed the title Rename text and label cols to input and target output Chore: Rename text and label cols to input and target output Jul 21, 2023
@elboy3 elboy3 marked this pull request as ready for review July 21, 2023 21:15
@elboy3 elboy3 requested review from a team and dcaustin33 as code owners July 21, 2023 21:15
Comment on lines +222 to +223
data_df.rename("text", "input")
data_df.rename("label", "target_output")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rename here instead of when we create data_df?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could have. due to the inheritance from base and the assumptions of text and label in the DF for all modalities, there might be some places the code assumes "text" in DF, so I decided to wait until the very end to rename.

I was going to come back to this after demo and clean it up though which was going to include looking into breaking up that assumption about text and label and replacing it with more Seq2Seq appropriate jargon

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #718 (14d7885) into main (1820911) will decrease coverage by 0.03%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   89.55%   89.53%   -0.03%     
==========================================
  Files         166      166              
  Lines       13397    13394       -3     
==========================================
- Hits        11998    11992       -6     
- Misses       1399     1402       +3     
Impacted Files Coverage Δ
dataquality/loggers/data_logger/seq2seq.py 79.80% <0.00%> (-1.57%) ⬇️
dataquality/loggers/model_logger/seq2seq.py 92.18% <100.00%> (+0.38%) ⬆️
dataquality/schemas/seq2seq.py 100.00% <100.00%> (ø)
tests/loggers/test_seq2seq.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elboy3 elboy3 merged commit 22a1a40 into main Jul 21, 2023
@elboy3 elboy3 deleted the fix/rename-cols branch July 21, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants