Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pydantic below 2 #710

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Pin pydantic below 2 #710

merged 2 commits into from
Jul 10, 2023

Conversation

elboy3
Copy link
Contributor

@elboy3 elboy3 commented Jul 10, 2023

DQ doesn't work with pydantic 2

pydantic docs https://docs.pydantic.dev/dev-v2/migration/

>>> import dataquality
/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/pydantic/_internal/_config.py:261: UserWarning: Valid config keys have changed in V2:
* 'underscore_attrs_are_private' has been removed
  warnings.warn(message, UserWarning)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/dataquality/__init__.py", line 39, in <module>
    import dataquality.core._config
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/dataquality/core/__init__.py", line 6, in <module>
    from dataquality.analytics import Analytics
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/dataquality/analytics.py", line 10, in <module>
    from dataquality.clients.api import ApiClient
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/dataquality/clients/api.py", line 14, in <module>
    from dataquality.schemas.dataframe import FileType
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/dataquality/schemas/dataframe.py", line 5, in <module>
    from vaex.dataframe import DataFrame
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/vaex/__init__.py", line 41, in <module>
    import vaex.logging
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/vaex/logging.py", line 7, in <module>
    import vaex.settings
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/vaex/settings.py", line 10, in <module>
    from pydantic import BaseModel, BaseSettings, Field
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/pydantic/__init__.py", line 206, in __getattr__
    return _getattr_migration(attr_name)
  File "/Users/elliottchartock/Code/.venv/lib/python3.9/site-packages/pydantic/_migration.py", line 279, in wrapper
    raise PydanticImportError(
pydantic.errors.PydanticImportError: `BaseSettings` has been moved to the `pydantic-settings` package. See https://docs.pydantic.dev/2.0.2/migration/#basesettings-has-moved-to-pydantic-settings for more details.

For further information visit https://errors.pydantic.dev/2.0.2/u/import-error

@elboy3 elboy3 requested review from a team and dcaustin33 as code owners July 10, 2023 14:23
@elboy3 elboy3 merged commit 33197c2 into main Jul 10, 2023
@elboy3 elboy3 deleted the fix/pin-pydantic-below-2 branch July 10, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants