Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move version validation to init, log warning instead of raising exception #708

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

setu4993
Copy link
Member

@setu4993 setu4993 commented Jul 7, 2023

Add test for #707.

@setu4993 setu4993 requested review from a team and dcaustin33 as code owners July 7, 2023 18:47
tests/utils/test_version.py Outdated Show resolved Hide resolved
@setu4993 setu4993 changed the title test: Add test for version mismatch fix: Move version validation to init, log warning instead of raising exception Jul 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #708 (fdc6fc7) into main (c51eedd) will decrease coverage by 0.03%.
The diff coverage is 98.11%.

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   89.62%   89.60%   -0.03%     
==========================================
  Files         166      166              
  Lines       13278    13279       +1     
==========================================
- Hits        11901    11899       -2     
- Misses       1377     1380       +3     
Impacted Files Coverage Δ
dataquality/core/finish.py 100.00% <ø> (ø)
tests/core/test_finish.py 100.00% <ø> (ø)
tests/loggers/test_tabular_classification.py 100.00% <ø> (ø)
tests/test_utils/mock_request.py 70.27% <ø> (-0.25%) ⬇️
dataquality/utils/version.py 94.44% <75.00%> (-5.56%) ⬇️
dataquality/core/init.py 93.96% <100.00%> (+0.10%) ⬆️
tests/core/test_init.py 100.00% <100.00%> (ø)
tests/integrations/fastai/test_cv_fai.py 100.00% <100.00%> (ø)
tests/integrations/fastai/test_text_fai.py 100.00% <100.00%> (ø)
...sts/integrations/hf/test_text_classification_hf.py 100.00% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@setu4993 setu4993 enabled auto-merge (squash) July 7, 2023 20:57
@setu4993 setu4993 merged commit a30bf68 into main Jul 7, 2023
@setu4993 setu4993 deleted the tests/version branch July 7, 2023 20:57
bogdan-galileo pushed a commit that referenced this pull request Jul 10, 2023
bogdan-galileo pushed a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants