Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cv save local paths #704

Merged
merged 37 commits into from
Jul 25, 2023
Merged

Feat/cv save local paths #704

merged 37 commits into from
Jul 25, 2023

Conversation

bogdan-galileo
Copy link
Contributor

@bogdan-galileo bogdan-galileo commented Jul 6, 2023

Main goal is to start logging the local paths to images for IC (necessary for the smart features to run: blurriness, bad exposure, etc), see ticket https://app.shortcut.com/galileo/story/6278/cv-allow-logging-for-local-images

  • added a non_metadata attribute to the TC logger, which works and logs data like metadata, but doesn't show up in the UI
  • cleaned up and simplified the interface to log_image_dataset + updated docstring
  • added lots of tests for log_image_dataset covering all scenarios

Probably require minor version bump as it's not backwards compatible

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #704 (b668bc5) into main (1820911) will increase coverage by 0.26%.
The diff coverage is 98.19%.

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   89.55%   89.82%   +0.26%     
==========================================
  Files         166      167       +1     
  Lines       13397    13579     +182     
==========================================
+ Hits        11998    12197     +199     
+ Misses       1399     1382      -17     
Impacted Files Coverage Δ
dataquality/core/log.py 95.55% <ø> (ø)
...quality/loggers/data_logger/text_classification.py 92.78% <ø> (+0.51%) ⬆️
dataquality/utils/hf_images.py 94.44% <ø> (+7.48%) ⬆️
tests/test_utils/mock_data.py 92.85% <86.36%> (-7.15%) ⬇️
...uality/loggers/data_logger/image_classification.py 87.59% <97.56%> (+12.59%) ⬆️
dataquality/integrations/fastai.py 86.75% <100.00%> (+0.06%) ⬆️
...ataquality/loggers/data_logger/base_data_logger.py 89.40% <100.00%> (+0.41%) ⬆️
tests/integrations/fastai/test_cv_fai.py 98.03% <100.00%> (ø)
tests/loggers/test_image_classification.py 100.00% <100.00%> (ø)
tests/loggers/test_log_image_dataset.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bogdan-galileo bogdan-galileo marked this pull request as ready for review July 7, 2023 13:46
@bogdan-galileo bogdan-galileo requested review from a team and dcaustin33 as code owners July 7, 2023 13:47
Copy link
Contributor

@anthonycorletti anthonycorletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@elboy3 elboy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bogdan-galileo bogdan-galileo merged commit 1b76d2b into main Jul 25, 2023
@bogdan-galileo bogdan-galileo deleted the feat/cv-save-local-paths branch July 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants