downcast before saving batch #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 89.50% 89.47% -0.04%
==========================================
Files 166 166
Lines 13241 13250 +9
==========================================
+ Hits 11851 11855 +4
- Misses 1390 1395 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bogdan-galileo
pushed a commit
that referenced
this pull request
Jul 10, 2023
we've done this in a few places before uploading to Galileo, but we still write the batches to disk. This can really add up (f64 embeddings are huge). Safely always downcast before writing to disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've done this in a few places before uploading to Galileo, but we still write the batches to disk. This can really add up (f64 embeddings are huge).
Safely always downcast before writing to disk