chore: faster build install #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Epstein
reviewed
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 167 167
Lines 13305 13305
=======================================
Hits 11226 11226
Misses 2079 2079 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ben-Epstein
approved these changes
Jun 9, 2023
franz101
reviewed
Jun 9, 2023
There was a problem hiding this comment.
setu4993
reviewed
Jun 9, 2023
There was a problem hiding this comment.
If we are open to updating the build system, I do strongly think we should go the route of safer build systems like poetry which provide us the type of checks we need for packages like dataquality. A few features that would help:
- Strict dependency resolution.
- Easy management of dependencies across extras.
- Simple dependency upgrades.
franz101
pushed a commit
that referenced
this pull request
Jun 14, 2023
* [ ] I have added tests to `tests` to cover my changes. * [x] I have updated `docs/`, if necessary. * [ ] I have updated the `README.md`, if necessary. ***What existing issue does this pull request close?*** No issue 🎩 👉 🐇 ***How are these changes tested?*** locally and ci ***Provide additional context.*** - build system: setuptools for consistency with other projects, simplicity, and stability - consolidated all? configs to pyproject.toml - replaced bash scripts with invoke to be more pythonic 🐍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teststo cover my changes.docs/, if necessary.README.md, if necessary.What existing issue does this pull request close?
No issue 🎩 👉 🐇
How are these changes tested?
locally and ci
Provide additional context.