Fix SetFit notebook issues v1 #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 83.97% 84.37% +0.39%
==========================================
Files 167 167
Lines 13227 13274 +47
==========================================
+ Hits 11108 11200 +92
+ Misses 2119 2074 -45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ben-Epstein
reviewed
Jun 6, 2023
Ben-Epstein
reviewed
Jun 6, 2023
dataquality/utils/setfit.py
Outdated
| @@ -62,6 +63,8 @@ def log_preds_setfit( | |||
|
|
|||
| logger_config = dq.get_data_logger().logger_config | |||
| labels = logger_config.labels | |||
| epoch = 0 if epoch is None else epoch | |||
There was a problem hiding this comment.
slightly cleaner. If epoch is None or 0, itll be set to 0, otherwise, itll be kept
Suggested change
| epoch = 0 if epoch is None else epoch | |
| epoch = epoch or 0 |
Ben-Epstein
reviewed
Jun 6, 2023
Ben-Epstein
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified issues:
Issues when running the dq_evaluate due to the automatic removal of the patches
Further investigation:
Essentiallty the cleanup manager removed the patch. The other issue was that it was checking for the config before it was initialized.