Compute iou locally #638
Merged
Compute iou locally #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboy3
reviewed
May 31, 2023
| # fill the nans with 0s | ||
| union_pixels_per_class = np.nan_to_num(union_pixels_per_class) | ||
|
|
||
| return iou_per_class, union_pixels_per_class |
There was a problem hiding this comment.
so iou per class can have nans but not area per class?
There was a problem hiding this comment.
Yeah IoU of 0 has a meaning (ie no intersection) so we keep it as nan vs 0 area is the correct terminology when we have nan in area
elboy3
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute iou locally instead of hitting hf hub - reduces dependency on hf hub and speeds up by about 4 seconds for 20 examples (55 down to 51) think this can be optimized further