Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notebooks): Fix notebooks to run correctly #632

Merged
merged 3 commits into from
May 31, 2023

Conversation

setu4993
Copy link
Member

I was running these notebooks locally to test a few things and ran into them not working correctly, so just checking in the fixes I had to make.

No functional changes to dataquality.

Changes:

  • fix: Update E2E NLP notebook with recent changes
  • fix: Equal embedding dimensions in inference notebook

Tests:

  • Notebooks run fine locally.

@setu4993 setu4993 requested a review from a team as a code owner May 24, 2023 20:06
@codecov-commenter
Copy link

Codecov Report

Merging #632 (bdda0c7) into main (483acdb) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   84.39%   84.43%   +0.03%     
==========================================
  Files         164      165       +1     
  Lines       12964    12970       +6     
==========================================
+ Hits        10941    10951      +10     
+ Misses       2023     2019       -4     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@franz101 franz101 enabled auto-merge (squash) May 31, 2023 20:23
@franz101 franz101 merged commit c6c552f into main May 31, 2023
@franz101 franz101 deleted the chore/update-notebooks branch May 31, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants