Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: include polygon area(#3) #625

Merged
merged 16 commits into from
May 22, 2023
Merged

Feature: include polygon area(#3) #625

merged 16 commits into from
May 22, 2023

Conversation

dcaustin33
Copy link
Contributor

@dcaustin33 dcaustin33 commented May 22, 2023

Includes polygon area in polygon shema and df

https://app.shortcut.com/galileo/story/5485/dq-add-area-to-polygon

@dcaustin33 dcaustin33 requested a review from a team as a code owner May 22, 2023 16:27
@dcaustin33 dcaustin33 changed the title Feature #3 include polygon area Feature: include polygon area(#3) May 22, 2023
@elboy3 elboy3 changed the base branch from main to chore/ghost_error_polygon May 22, 2023 17:56
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #625 (a13d2be) into main (b1ceccb) will increase coverage by 0.64%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   83.91%   84.56%   +0.64%     
==========================================
  Files         164      164              
  Lines       12910    12937      +27     
==========================================
+ Hits        10834    10940     +106     
+ Misses       2076     1997      -79     
Impacted Files Coverage Δ
...lity/loggers/model_logger/semantic_segmentation.py 0.00% <0.00%> (ø)
dataquality/schemas/semantic_segmentation.py 79.66% <100.00%> (+4.15%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from chore/ghost_error_polygon to main May 22, 2023 18:16
Copy link
Contributor

@elboy3 elboy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bloody brilliant

@elboy3 elboy3 merged commit 2628913 into main May 22, 2023
@elboy3 elboy3 deleted the chore/include_polygon_area branch May 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants