Cuda errors and pred dep #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Epstein
approved these changes
May 18, 2023
elboy3
reviewed
May 18, 2023
| dep = ( | ||
| polygon.data_error_potential | ||
| if polygon.data_error_potential | ||
| else 0.5 |
There was a problem hiding this comment.
i woudln't commit this to code for now, but just change it on your local to create the runs
elboy3
reviewed
May 18, 2023
| dep = ( | ||
| polygon.data_error_potential | ||
| if polygon.data_error_potential | ||
| else 0.5 |
elboy3
reviewed
May 18, 2023
| @@ -2,9 +2,20 @@ | |||
| "cells": [ | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": null, | |||
There was a problem hiding this comment.
remove from version control
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 84.75% 84.66% -0.09%
==========================================
Files 163 163
Lines 12840 12845 +5
==========================================
- Hits 10882 10875 -7
- Misses 1958 1970 +12
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some cuda errors in our hook and changed dep to pass linting / not be null for now