Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference + alert clearing for reprocess_run #610

Merged
merged 2 commits into from
May 18, 2023

Conversation

Ben-Epstein
Copy link
Contributor

  1. Remove alerts before reprocessing
  2. Handle inference and non-inference case

Tested with a run with inference and without

image

@Ben-Epstein Ben-Epstein requested a review from a team as a code owner May 18, 2023 14:41
@Ben-Epstein Ben-Epstein self-assigned this May 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #610 (a247eff) into main (453412f) will decrease coverage by 0.14%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   84.87%   84.73%   -0.14%     
==========================================
  Files         163      163              
  Lines       12817    12840      +23     
==========================================
+ Hits        10878    10880       +2     
- Misses       1939     1960      +21     
Impacted Files Coverage Δ
dataquality/internal.py 0.00% <0.00%> (ø)
dataquality/clients/api.py 51.82% <13.04%> (-2.90%) ⬇️
dataquality/schemas/route.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Ben-Epstein Ben-Epstein merged commit 40b908d into main May 18, 2023
@Ben-Epstein Ben-Epstein deleted the reprocess-run-remove-alerts-process-inference branch May 18, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants