Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon uuid as strs #606

Merged
merged 3 commits into from
May 18, 2023
Merged

Polygon uuid as strs #606

merged 3 commits into from
May 18, 2023

Conversation

elboy3
Copy link
Contributor

@elboy3 elboy3 commented May 17, 2023

whoops

@elboy3 elboy3 requested a review from a team as a code owner May 17, 2023 20:32
setu4993
setu4993 reviewed May 17, 2023
View reviewed changes
Copy link
Member

@setu4993 setu4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question... Is it easy to add a test for this?

dataquality/schemas/semantic_segmentation.py
@@ -47,7 +47,7 @@ class Contour(BaseModel):


class Polygon(BaseModel):
uuid: UUID4
uuid: str # UUID4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This with UUID4 should work since we're passing in the str version of it from polygons.py, right?

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #606 (b4d6aa5) into main (224cc80) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files         163      163           
  Lines       12815    12815           
=======================================
  Hits        10878    10878           
  Misses       1937     1937
Impacted Files Coverage Δ
...ataquality/utils/semantic_segmentation/polygons.py 0.00% <ø> (ø)
dataquality/schemas/semantic_segmentation.py 74.46% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elboy3 elboy3 enabled auto-merge (squash) May 17, 2023 21:01
@elboy3 elboy3 disabled auto-merge May 17, 2023 21:13
@dcaustin33 dcaustin33 enabled auto-merge (squash) May 18, 2023 01:31
@dcaustin33 dcaustin33 merged commit 7e2a0c2 into main May 18, 2023
@dcaustin33 dcaustin33 deleted the fix/whoops branch May 18, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setu4993 setu4993 setu4993 left review comments

@anthonycorletti anthonycorletti anthonycorletti approved these changes

@Ben-Epstein Ben-Epstein Ben-Epstein approved these changes

@dcaustin33 dcaustin33 dcaustin33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elboy3 @codecov-commenter @setu4993 @anthonycorletti @Ben-Epstein @dcaustin33