Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring trainer to support to run prediction and unwatch on dq.finish #595

Merged
merged 6 commits into from
May 15, 2023

Conversation

franz101
Copy link
Contributor

@franz101 franz101 commented May 12, 2023

  • Use Patch class
  • Unwatch on dq.finish / config reset
  • Be able to load trainer from checkpoint and run inference

@franz101 franz101 marked this pull request as ready for review May 12, 2023 07:07
@franz101 franz101 requested a review from a team as a code owner May 12, 2023 07:07
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #595 (ce89a72) into main (88a1422) will increase coverage by 0.07%.
The diff coverage is 91.57%.

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   84.88%   84.96%   +0.07%     
==========================================
  Files         161      161              
  Lines       12598    12688      +90     
==========================================
+ Hits        10694    10780      +86     
- Misses       1904     1908       +4     
Impacted Files Coverage Δ
dataquality/utils/torch.py 80.42% <75.00%> (+0.42%) ⬆️
dataquality/utils/transformers.py 89.18% <88.33%> (-7.79%) ⬇️
dataquality/integrations/transformers_trainer.py 94.73% <97.29%> (+6.27%) ⬆️
dataquality/integrations/setfit.py 55.00% <100.00%> (-6.25%) ⬇️
dataquality/utils/patcher.py 100.00% <100.00%> (ø)
...sts/integrations/hf/test_text_classification_hf.py 100.00% <100.00%> (ø)
tests/start/test_start_auto.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines +309 to +311
assert trainer.args.n_gpu <= 1, GalileoException(
"Parallel GPUs are not supported. TrainingArguments.n_gpu should be set to 1"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franz101 franz101 merged commit 3acc820 into main May 15, 2023
@franz101 franz101 deleted the features/trainer2 branch May 15, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants