Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/semseg polygon dep #592

Merged
merged 18 commits into from
May 12, 2023
Merged

Feature/semseg polygon dep #592

merged 18 commits into from
May 12, 2023

Conversation

dcaustin33
Copy link
Contributor

Adds polygon dep as an attribute and compute dep for each polygon.
Also adds a helper function to polygon_data to make it more readable

@dcaustin33 dcaustin33 requested a review from a team as a code owner May 11, 2023 20:55
@dcaustin33 dcaustin33 requested a review from elboy3 May 11, 2023 20:55
Comment on lines 201 to 202
height=[img.shape[-1] for img in self.gold_masks],
width=[img.shape[-2] for img in self.gold_masks],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duplicated on 210 below, lets just call it once and reuse var

Copy link
Contributor

@elboy3 elboy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice! can you create a new run called polygon-dep to test before you merge?

i can take a look at the processed DF and make sure it saved right

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #592 (6bfb3fe) into main (88a1422) will decrease coverage by 0.17%.
The diff coverage is 1.72%.

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   84.88%   84.71%   -0.17%     
==========================================
  Files         161      161              
  Lines       12598    12624      +26     
==========================================
+ Hits        10694    10695       +1     
- Misses       1904     1929      +25     
Impacted Files Coverage Δ
...ity/integrations/cv/torch/semantic_segmentation.py 0.00% <0.00%> (ø)
...lity/loggers/model_logger/semantic_segmentation.py 0.00% <0.00%> (ø)
dataquality/utils/semantic_segmentation/errors.py 0.00% <0.00%> (ø)
dataquality/schemas/semantic_segmentation.py 74.46% <100.00%> (+0.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dcaustin33 dcaustin33 merged commit 15694a5 into main May 12, 2023
@dcaustin33 dcaustin33 deleted the feature/semseg_polygon_dep branch May 12, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants