fix(windows-installer): uninstall script behavior #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Shubhranshu153
approved these changes
Feb 20, 2024
|
Overriding single Windows test flake since this change is not tested by it |
mharwani
pushed a commit
that referenced
this pull request
Feb 21, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.2](v1.1.1...v1.1.2) (2024-02-20) ### Build System or External Dependencies * **deps:** Bump github.com/docker/docker from 25.0.1+incompatible to 25.0.3+incompatible ([#799](#799)) ([d761301](d761301)) * **deps:** Bump github.com/goccy/go-yaml from 1.11.2 to 1.11.3 ([#780](#780)) ([2e616ff](2e616ff)) * **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.12 to 3.24.1 ([#787](#787)) ([55f6d92](55f6d92)) * **deps:** Bump golang.org/x/crypto from 0.18.0 to 0.19.0 ([#806](#806)) ([3fbc87c](3fbc87c)) * **deps:** Bump golang.org/x/tools from 0.17.0 to 0.18.0 ([#807](#807)) ([7323751](7323751)) * **deps:** Bump k8s.io/apimachinery from 0.29.1 to 0.29.2 ([#820](#820)) ([6ca0f7f](6ca0f7f)) * **deps:** Bump submodules and dependencies ([#795](#795)) ([ec77f1a](ec77f1a)) * **deps:** Bump submodules and dependencies ([#805](#805)) ([0bf9148](0bf9148)) ### Bug Fixes * Correct typo in type name of struct (NerdctlClientOuput) ([#743](#743)) ([13de2b9](13de2b9)) * Env variable CONTAINERD_SNAPSHOTTER cleared on overlayfs and ref… ([#816](#816)) ([d222a34](d222a34)) * msi release tests cleanup ([#819](#819)) ([0f23660](0f23660)) * stop Finch on uninstall ([#818](#818)) ([a96788b](a96788b)) * **windows-installer:** add new cleanup script on install ([#824](#824)) ([fccfa1d](fccfa1d)) * **windows-installer:** ignore FilesInUse/Restart dialogue ([#823](#823)) ([f64835d](f64835d)) * **windows-installer:** uninstall script behavior ([#822](#822)) ([ace37ea](ace37ea)) ### Reverts * "always force stop when using Virtualization.framework" ([#370](#370)) ([cb3051e](cb3051e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
&separators. After that, I noticed that the WSL commands would fail immediately. This was because the commands were being executed as a Local install user, instead of the target user. ChangingImpersonatetoyesshould resolve that issue (docs).Description of changes:
ImpersonatetoyesTesting done:
Local testing
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.