ci(bug-fix): use local registry for VZ/Rosetta tests #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
|
Looks like there's one remaining issue of the http default server never being cleaned up, which causes a "duplicate handler for /" error. |
1 task
pendo324
added a commit
to runfinch/common-tests
that referenced
this pull request
Apr 6, 2023
Issue #, if available: runfinch/finch#322, specifically regarding this comment runfinch/finch#327 (comment) *Description of changes:* - instantiate a new `NewServeMux` every time the test is run - use the `SpecContext` context instead of the default background context *Testing done:* - tested by using go.mod `replace ()` and running tests locally - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
sam-berning
reviewed
Apr 6, 2023
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
sam-berning
reviewed
Apr 6, 2023
|
Overriding merge, last test run just had a flaky compose test (known issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #322
Description of changes:
Testing done:
Local testing
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.