docs: design of adding config to support additional directories #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
vsiravar
reviewed
Dec 15, 2022
pendo324
reviewed
Dec 15, 2022
mharwani
reviewed
Dec 15, 2022
vsiravar
reviewed
Dec 15, 2022
mharwani
reviewed
Dec 15, 2022
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
pendo324
previously approved these changes
Dec 20, 2022
mharwani
previously approved these changes
Dec 20, 2022
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
pendo324
approved these changes
Dec 20, 2022
mharwani
approved these changes
Dec 20, 2022
ningziwen
added a commit
that referenced
this pull request
Dec 26, 2022
Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: #107 *Description of changes:* add config to support additional directories according to the doc added in #123 *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
ahsan-z-khan
pushed a commit
to ahsan-z-khan/finch
that referenced
this pull request
Jan 11, 2023
…inch#123) Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: runfinch#107 *Description of changes:* Doc *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
ahsan-z-khan
pushed a commit
to ahsan-z-khan/finch
that referenced
this pull request
Jan 11, 2023
Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: runfinch#107 *Description of changes:* add config to support additional directories according to the doc added in runfinch#123 *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziwen Ning ningziwe@amazon.com
Issue #, if available:
#107
Description of changes:
Doc
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.