Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(linux): add Linux packaging and e2e tests #1071

Merged
merged 56 commits into from
Sep 18, 2024
Merged

build(linux): add Linux packaging and e2e tests #1071

merged 56 commits into from
Sep 18, 2024

Conversation

pendo324
Copy link
Member

@pendo324 pendo324 commented Aug 23, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • Add packaging and e2e runners which use the packages to run tests
  • Before merging this, we need to:
    • add linux runners to this repository (by merging feat: add linux runners infrastructure#683)
    • remove the change in this PR which makes it so CI runs on all branches, not just main
    • uncomment the disabling of the macOS/Windows runners

Testing done:

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pendo324 added 30 commits June 26, 2024 19:29
@pendo324
feat(wip): allow finch to build on Linux without Lima
1819ee1 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix Makefile
4ad889d 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
refactor lima_cmd_creator => nerdctl_cmd_creator
3bdf5c8 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix some refactoring/renaming misses
01b5b73 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix unit tests
26c56dc 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
Merge branch 'main' into linux
bf18a4d 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix linting
7c52c4d 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
remove unnecessary mockgen call
efc06d5 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
remove unused code
44b2fd5 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix windows unit tests
e4c14ed 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix linux linting errors
e65052c 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
refactor to use standard Linux config path
b6a070b 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
update docs
6e4ab1b 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix shared settings not being inlined
0712bcd 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
refactor support bundles to only export files that would be relevant …
eec59bf 
…on Linux

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
update build guards
8b454e7 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix FinchRootDir
6fbb0ec 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
refactor cmd/nerdctl for Linux
5f0d7cf 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
refactor nerdctl to use custom paths for buildkit socket and nerdctl.…
03e23ef 
…toml

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix linting
350d07f 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
automatically set the NATIVE_BUILD parameter if using Linux since tha…
d2e45f9 
…t's the only supported config

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
allow GITCOMMIT to be overwritten to make RPM builds easier
11fadda 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
finch-general => finch-all
cba2d82 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
main_local.go => main_native.go
4dc7985 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
remove ensureCredentials check in native mode
dc6688b 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
virtual_machine_local.go => virtual_machine_native.go
72f0ce9 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
ensure all remote only tests have _remote suffix
2a3c9f5 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
prepend path to vended buildkit binaries for Fedora-based systems
564aa7d 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix Makefile not handling default case for NATIVE_BUILD not on Linux
d84a7f5 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
simplify makefile
5b15065 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
Merge branch 'main' into linux
b6fe134 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
Merge branch 'linux' into linux-packaging-testing
e0138e7 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix typo in help replacement logic
b90ebb2 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
minor updates to spec file
52ffc3b 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
revert temporary changes to workflows
c1c3edc 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 changed the base branch from linux to main September 17, 2024 23:23
@pendo324
Merge branch 'main' into linux-packaging-testing
70b7f9d 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix merge mistakes
1852e62 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
reorder test matrices for better readability
2d7532b 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix unit test
923a68f 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix nerdctl_native test
a3f75f8 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
enable ARM runners
d648225 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Shubhranshu153
Shubhranshu153 previously approved these changes Sep 18, 2024
View reviewed changes
swagatbora90
swagatbora90 reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@swagatbora90 swagatbora90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Looks good otherwise.

@pendo324
address comments
dd962aa 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix directory permissions (allows non-root to list dir)
05465b5 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix path to finch dir
e5e9700 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix nerdctl.toml path
344a581 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix windows runner arch to match real infra
0f3ed06 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
remove faulty version tag from windows matrix
684f95a 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
Copy link
Member Author

The e2e test names changed due to renaming / splitting them into different files. After merging, I'll have to change the "required checks" in the GitHub settings.

@pendo324 pendo324 merged commit 985570e into runfinch:main Sep 18, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swagatbora90 swagatbora90 swagatbora90 approved these changes

@Shubhranshu153 Shubhranshu153 Awaiting requested review from Shubhranshu153

Assignees

@pendo324 pendo324

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pendo324 @swagatbora90 @Shubhranshu153