Skip to content

Commit

Permalink
ci: fix release workflows (#815)
Browse files Browse the repository at this point in the history
Issue #, if available: 
-
https://github.com/runfinch/finch/actions/runs/7898818699/job/21557140881#step:15:50
-
https://github.com/runfinch/finch/actions/runs/7898798501/job/21557606364#step:12:6625


*Description of changes:*
- Accidentally removed the "installed" flag from our e2e tests that
validate installed versions of Finch, this fixes that


*Testing done:*


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
  • Loading branch information
pendo324 authored Feb 14, 2024
1 parent cb3051e commit 6188a2c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build-and-test-msi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ jobs:
git status
git clean -f -d
$env:INSTALLED="true"
make test-e2e-container
- name: Uninstall Finch silently
if: ${{ always() }}
Expand Down
12 changes: 5 additions & 7 deletions .github/workflows/build-and-test-pkg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ jobs:
# that caused the VM initialization failure in the e2e test.
# Example workflow run https://github.com/runfinch/finch/actions/runs/4367457552/jobs/7638794529
sudo installer -pkg Finch-${{ needs.get-tag-name.outputs.tag }}-aarch64.pkg -target /
- name: Run e2e tests
- name: Run VM e2e tests
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
with:
timeout_minutes: 180
Expand All @@ -217,16 +217,15 @@ jobs:
git status
git clean -f -d
INSTALLED=true make test-e2e-vm
make test-e2e-container
- name: Run e2e tests
- name: Run container e2e tests
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
with:
timeout_minutes: 180
max_attempts: 3
command: |
git status
git clean -f -d
make test-e2e-container
INSTALLED=true make test-e2e-container
- name: Silently uninstall
run: echo 'y' | sudo bash /Applications/Finch/uninstall.sh
- name: Delete installer
Expand Down Expand Up @@ -336,16 +335,15 @@ jobs:
git status
git clean -f -d
INSTALLED=true make test-e2e-vm
make test-e2e-container
- name: Run VM e2e tests
- name: Run container e2e tests
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
with:
timeout_minutes: 180
max_attempts: 3
command: |
git status
git clean -f -d
make test-e2e-container
INSTALLED=true make test-e2e-container
- name: Silently uninstall
run: echo 'y' | sudo bash /Applications/Finch/uninstall.sh
- name: Delete installer
Expand Down

0 comments on commit 6188a2c

Please sign in to comment.