Skip to content

Commit

Permalink
ci: Add codeowners file to finch (#501)
Browse files Browse the repository at this point in the history
Issue #, if available:
N/A.
*Description of changes:*
- Add `CODEOWNERS` file to finch to ensure that [release-please
PR](#483) which modifies`
CHANGELOG.md` has to be reviewed and approved by a member of
`@runfinch/dev-team` in order to kick off a finch release.
- Ensures that any changes to `.github` directory requires approval from
`@runfinch/dev-team`, i.e even modifications to `CODEOWNERS` would
require an approval from the team.
- Modifies `ci.yaml` to not run CI checks on `CODEOWNERS` file. 


*Testing done:*
Yes, on personal repo. 
See code owners setting in
[CODEOWNERS](https://github.com/vsiravar/github-actions-experiments/blob/main/.github/CODEOWNERS)
and test [requesting review from code
owner](vsiravar/github-actions-experiments#22)


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <siravara@amazon.com>
  • Loading branch information
vsiravar authored Jul 25, 2023
1 parent 6f1afbb commit 2ffa28f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# CHANGELOG generated by release-please action has to be approved by dev-team before creating a release.
/CHANGELOG.md @runfinch/dev-team

# Any changes to github workflows requires dev-team approval
/.github/ @runfinch/dev-team
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ on:
paths-ignore:
- '**.md'
- 'contrib/**'
- '.github/CODEOWNERS'
pull_request:
branches:
- main
paths-ignore:
- '**.md'
- 'contrib/**'
- '.github/CODEOWNERS'
permissions:
id-token: write
contents: write
Expand Down

0 comments on commit 2ffa28f

Please sign in to comment.