fix: extend compose down timeout to 30 seconds #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extends the timeout for compose down commands to 30 seconds. Beginning with nerdctl 2.0, compose down will attempt to gracefully teardown containers by sending SIGTERM with a 10 second timeout. For testing, common-tests is using stubborn containers, e.g. sleep infinity, which require sigkill to come down. For most test cases, this can be worked around by using compose stop/rm instead; however, for this test suite which needs to explicitly test compose down there is no workaround other than to extend the timeout to a value that makes sense. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
1bb92ca to
fccbdf5
Compare
|
Superseded by #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#206
Description of changes:
This change extends the timeout for compose down commands to 20 seconds. Beginning with nerdctl 2.0, compose down will attempt to gracefully teardown containers by sending SIGTERM with a 10 second timeout. For testing, common-tests is using stubborn containers, e.g. sleep infinity, which require sigkill to come down. For most test cases, this can be worked around by using compose stop/rm instead; however, for this test suite which needs to explicitly test compose down there is not workaround other than to extend the timeout to a value that makes sense.
Testing done:
Ran tests in runfinch/finch-core#472
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.