feat: add tests for finch cp #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
azhouwd
reviewed
Dec 7, 2022
Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
azhouwd
approved these changes
Dec 12, 2022
Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
1 task
mharwani
added a commit
to runfinch/finch
that referenced
this pull request
Jan 4, 2023
Issue #, if available: #82 *Description of changes:* Added `finch cp` command and its e2e tests (runfinch/common-tests#11). *Testing done:* Unit tests and E2E tests. - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
ahsan-z-khan
pushed a commit
to ahsan-z-khan/finch
that referenced
this pull request
Jan 11, 2023
Issue #, if available: runfinch#82 *Description of changes:* Added `finch cp` command and its e2e tests (runfinch/common-tests#11). *Testing done:* Unit tests and E2E tests. - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mrudul Harwani mharwani@amazon.com
Issue #, if available:
runfinch/finch#82
Description of changes:
Adding e2e tests for finch cp command
Testing done:
Tests passed locally
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
BEGIN_COMMIT_OVERRIDE
feat: add tests for finch cp (#11)
Signed-off-by: Mrudul Harwani mharwani@amazon.com
Issue #, if available:
runfinch/finch#82
Description of changes:
Adding e2e tests for finch cp command
Testing done:
Tests passed locally
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
END_COMMIT_OVERRIDE