chore: use @runejs/store instead of filestore to remove canvas dependency
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendency the canvas dependency causes docker errors (`Error loading shared library ld-linux-x86-64.so.2`) and I noticed that the `@runejs/store` doesn't use it
|
Specifically, this package ( |
SchauweM
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the canvas dependency causes docker errors sometimes (
Error loading shared library ld-linux-x86-64.so.2) and I noticed that the@runejs/storedoesn't use it. So this seemed like a simpler fix than digging into that error..I am not sure if this is the correct fix, as I noticed that @Kikorono's branch of
filestorekiko/file-systemdoesn't have thecanvasdependency either (but is called@runejs/store)