Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1744 first node load is synchronous #1769

Merged
merged 11 commits into from
Mar 25, 2016

Conversation

gschueler
Copy link
Member

Asynch nodes cache new behavior:

  • If a project nodes cache file exists, initial load of project nodes will preload using this file
  • Otherwise initial load of project nodes is asynchronous, meaning you may see 0 nodes until they are loaded
    • this makes UI responsive after creating/saving project, and at startup
    • can force this to be synchronous using rundeck-config value: rundeck.nodeService.nodeCache.firstLoadAsynch=false
    • "Why would I want to force it to be synchronous?" If you deploy Rundeck with predefined jobs (e.g. new cluster node pointing at existing DB), this will force Rundeck to load all nodes prior to any jobs being executed, and may prevent spuriously failing jobs due to "no matched nodes"
  • Anytime the asynch cache successfully loads project nodes, it will write results to the local project nodes cache file, similar to existing cache files for individual model sources

bonus feature:

  • resource model source errors now shown in project config page

@gschueler gschueler added this to the 2.6.5 milestone Mar 25, 2016
@gschueler gschueler merged commit 75d83cb into rundeck:development Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant