-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Regenerates mock files with pegomock v4.1.0 #5090
Merged
X-Guardian
merged 4 commits into
runatlantis:main
from
tkasuz:pegomock-v4.1.0-regen-mock
Nov 16, 2024
Merged
chore: Regenerates mock files with pegomock v4.1.0 #5090
X-Guardian
merged 4 commits into
runatlantis:main
from
tkasuz:pegomock-v4.1.0-regen-mock
Nov 16, 2024
+4,320
−3,553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkasuz
requested review from
jamengual,
lukemassa and
X-Guardian
and removed request for
a team
November 14, 2024 14:46
github-actions
bot
added
provider/azuredevops
go
Pull requests that update Go code
provider/github
provider/gitlab
labels
Nov 14, 2024
dosubot
bot
added
the
refactoring
Code refactoring that doesn't add additional functionality
label
Nov 14, 2024
Signed-off-by: tkasuz <63289889+tkasuz@users.noreply.github.com>
tkasuz
force-pushed
the
pegomock-v4.1.0-regen-mock
branch
from
November 15, 2024 03:02
e730c0b
to
b6cdd7d
Compare
Thanks for this @tkasuz. Would you mind also taking a look at CONTRIBUTING.md#mocks and see if it needs updating too. That initial install comment looks out-of-date at least. |
- Replaced outdated install command with the latest one - Removed mention of go get, as it is no longer required for installing the binary Signed-off-by: tkasuz <63289889+tkasuz@users.noreply.github.com>
@X-Guardian Updated some outdated instructions 👍 |
X-Guardian
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tkasuz, looks good.
1 task
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
Signed-off-by: tkasuz <63289889+tkasuz@users.noreply.github.com>
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
Signed-off-by: tkasuz <63289889+tkasuz@users.noreply.github.com> Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
go
Pull requests that update Go code
lgtm
This PR has been approved by a maintainer
provider/azuredevops
provider/github
provider/gitlab
refactoring
Code refactoring that doesn't add additional functionality
waiting-on-response
Waiting for a response from the user
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The current version of
pegomock
is v4.1.0, but the mock files in use are still generated with v4.0.0. In v4.1.0, certain mock generation variables have been renamed.why
tests
references
renovate PR is #4832