-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add v1.6.2 opentofu binary to container #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
force-pushed
the
opentofu
branch
6 times, most recently
from
March 12, 2024 01:52
1ae1aa8
to
0951208
Compare
nitrocode
requested review from
jamengual,
lukemassa and
X-Guardian
and removed request for
a team
March 12, 2024 02:00
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
jamengual
reviewed
Mar 12, 2024
GenPage
approved these changes
Mar 23, 2024
nitrocode
changed the title
feat: add opentofu binary to container
feat: add v1.6.2 opentofu binary to container
Mar 24, 2024
1 task
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com> Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
shellcheck
onscripts/download-release.sh
hadolint
onDockerfile
why
COMMAND_DIR
for backwards compatibility but I don't think we should store a directory of terraform versions in here because using tf instead of terraform and opentofu instead of tofu is inconsistent. It's also necessary or there will be softlink conflicts. I'd prefer to store the binaries in a separate directory so we can keep the dir names consistent with the binaries.tofu
is used instead ofopentofu
is becausetofu
is their official binary nametests
references