docs: Update Document for server-side-repo-config.md #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update document for Metric on repo config
lukemassa
reviewed
Dec 20, 2023
Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
chenrui333
approved these changes
Dec 26, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Update server-side-repo-config.md Update document for Metric on repo config * docs(server-side-repo-config): fix case Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com> --------- Co-authored-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Update server-side-repo-config.md Update document for Metric on repo config * docs(server-side-repo-config): fix case Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com> --------- Co-authored-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
1 task
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
* Update server-side-repo-config.md Update document for Metric on repo config * docs(server-side-repo-config): fix case Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com> --------- Co-authored-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com>
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
* Update server-side-repo-config.md Update document for Metric on repo config * docs(server-side-repo-config): fix case Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com> --------- Co-authored-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Luke Massa <lukefrederickmassa@gmail.com> Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update document for Metric on repo config
what
Document failed to describe metrics at the root level metric of repo configuration
why
Because it's incorrect and misleading
https://github.com/runatlantis/atlantis/blob/main/server/core/config/raw/global_cfg.go#L18
tests
NA
references
https://github.com/runatlantis/atlantis/blob/main/server/core/config/raw/global_cfg.go#L18