Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): fix atlantis import test #2970

Merged
merged 4 commits into from
Jan 12, 2023
Merged

chore(test): fix atlantis import test #2970

merged 4 commits into from
Jan 12, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jan 12, 2023

what

  • fix atlantis import test

why

  • Previous PR ran tests but not e2e tests. The e2e tests failed after the PR merge.

{
Description: "import workspace",
RepoDir: "import-workspace",
Comments: []string{
"atlantis import -d dir1 -w ops 'random_id.dummy1[0]' AA",
"atlantis import -p dir1-ops 'random_id.dummy2[0]' BB",
"atlantis plan -p dir1-ops",
},
ExpReplies: [][]string{
{"exp-output-import-dir1-ops-dummy1.txt"},
{"exp-output-import-dir1-ops-dummy2.txt"},
{"exp-output-plan.txt"},
{"exp-output-merge.txt"},
},
},

tests

  • I have tested my changes by running e2e tests in this PR

references

@nitrocode nitrocode requested a review from a team as a code owner January 12, 2023 00:49
@nitrocode nitrocode changed the title Fix e2e import test chore(test): fix e2e atlantis import test Jan 12, 2023
@Fabianoshz
Copy link
Contributor

Damm, you're quick, I will wait for this to rebase this PR

@nitrocode nitrocode changed the title chore(test): fix e2e atlantis import test chore(test): fix atlantis import test Jan 12, 2023
@nitrocode nitrocode enabled auto-merge (squash) January 12, 2023 01:18
@nitrocode nitrocode merged commit c94e63c into main Jan 12, 2023
@nitrocode nitrocode deleted the fix-e2e-import-test branch January 12, 2023 01:18
@chenrui333
Copy link
Member

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants