Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect orgAllowlist changes in helm chart #2416

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

zepeng811
Copy link
Contributor

@zepeng811 zepeng811 commented Jul 27, 2022

Background

the helm chart parameter for orgWhitelist have been deprecated since version 4.0.2 and have been replaced by orgAllowlist since this commit: runatlantis/helm-charts@89da1af. But the deployment instruction is still referencing the old parameter

Summary

  • updated orgWhitelist to orgAllowlist in deployment.md
  • updated the link in deployment.md pointing to --repo-allowlist in server-configuration.md (changed extension from .html to .md to make the link work when reading on GitHub, netlify will automatically convert to .html)
  • added a note to indicate orgWhitelist should still be used for helm chart versions prior to 4.0.2

@zepeng811 zepeng811 requested a review from a team as a code owner July 27, 2022 21:26
@jamengual jamengual merged commit 5abea67 into runatlantis:master Jul 27, 2022
@jamengual
Copy link
Contributor

thanks for the contribution @zepeng811

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…unatlantis#2416)

* correct orgWhitelist to orgAllowlist in deployment doc

* correct link to allowlist in server config doc

* try fix link
@nitrocode nitrocode added this to the v0.19.8 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants