Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vcs-status-name hardcoded in PullIsMergeable function #2312

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

michelmzs
Copy link
Contributor

@michelmzs michelmzs commented Jun 11, 2022

Fix for the #2304 issue, where a custom VCS Status Name is ignored in the PullIsMergeable function.

@michelmzs michelmzs changed the title fix: Get VCSStatusName from UserConfig fix: vcs-status-name hardcoded in PullIsMergeable function Jun 11, 2022
@michelmzs michelmzs force-pushed the fix-vcsstatusname branch 2 times, most recently from 0bf5844 to e0e8056 Compare June 15, 2022 02:08
@michelmzs michelmzs force-pushed the fix-vcsstatusname branch from e0e8056 to 8882336 Compare June 15, 2022 02:13
@michelmzs michelmzs marked this pull request as ready for review June 15, 2022 02:19
@michelmzs michelmzs requested a review from a team as a code owner June 15, 2022 02:19
@michelmzs michelmzs force-pushed the fix-vcsstatusname branch from 8882336 to 758803e Compare June 15, 2022 02:22
@jamengual jamengual merged commit df0d58d into runatlantis:master Jun 16, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…is#2312)

* feat: add userConfig.VCSStatusName to applyCommandRunner context

* fix: use vcsstatusname from context

* chore: normalize tests

* chore: update interface mock
@nitrocode nitrocode added this to the v0.19.5 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants